Use LLVMGPUTileandFuse instead of LLVMGPUVectorize for convolutions #19469
+23
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nirvedh <[email protected]>
Signed-off-by: Nirvedh <[email protected]>
nirvedhmeshram
force-pushed
the
deprecate_conv_vectorize
branch
from
7488daa to
523fcdf
Compare
nirvedhmeshram
requested review from
MaheshRavishankar,
qedawkins,
kuhar and
Groverkss
as code owners
Signed-off-by: Nirvedh <[email protected]>
kuhar
reviewed
Dec 13, 2024
kuhar
approved these changes
Dec 13, 2024
qedawkins
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR for convs that are not picked by VectorDistribute or TileAndFuse via IGEMM, we default lower them with TileAndFuse instead of using Vectorize pipeline. There doesnt seem to be a major performance impact in testing done with iree-kernel-benchmark as shown here and we can always look into improving the heuristics if performance is a problem.
Fixes #19478